FrankChen021 commented on code in PR #16024:
URL: https://github.com/apache/druid/pull/16024#discussion_r1571946413
##########
extensions-core/mysql-metadata-storage/src/test/java/org/apache/druid/firehose/sql/MySQLFirehoseDatabaseConnectorTest.java:
##########
@@ -338,29 +337,6 @@ public boolean isEnforceAllowedProperties()
);
}
- @Test
- public void testFindPropertyKeysFromInvalidConnectUrl()
Review Comment:
it makes sense to remove this duplicate test
##########
extensions-core/lookups-cached-global/src/test/java/org/apache/druid/query/lookup/namespace/JdbcExtractionNamespaceUrlCheckTest.java:
##########
@@ -156,46 +156,6 @@ public boolean isEnforceAllowedProperties()
}
);
}
-
- @Test
- public void testWhenInvalidUrlFormat()
- {
Review Comment:
why is this removed
##########
extensions-core/mysql-metadata-storage/src/test/java/org/apache/druid/metadata/storage/mysql/MySQLConnectorTest.java:
##########
@@ -57,16 +55,14 @@ public void testIsExceptionTransientMySql()
new MySQLConnectorSslConfig(),
MYSQL_DRIVER_CONFIG
);
- Assert.assertTrue(connector.connectorIsTransientException(new
MySQLTransientException()));
- Assert.assertTrue(connector.connectorIsTransientException(new
MySQLTransactionRollbackException()));
Assert.assertTrue(
connector.connectorIsTransientException(new SQLException("some
transient failure", "s0", 1317))
);
Assert.assertFalse(
connector.connectorIsTransientException(new SQLException("totally
realistic test data", "s0", 1337))
);
// this method does not specially handle normal transient exceptions
either, since it is not vendor specific
- Assert.assertFalse(
Review Comment:
why is it changed from assertFalse to assertTrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
