cryptoe commented on code in PR #16041:
URL: https://github.com/apache/druid/pull/16041#discussion_r1573172327
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -512,6 +516,8 @@ public boolean add(final Task task)
SinglePhaseParallelIndexTaskRunner.DEFAULT_USE_LINEAGE_BASED_SEGMENT_ALLOCATION
);
+ taskContextEnricher.enrichContext(task);
Review Comment:
Yes this is a very critical flow for druid. We cannot allow extensions to
break this.
I would go one step further and add a future return type to the interface to
.
```
class TaskEnrichContext{
Future<Void> enrichContext(Task task)
}
```
and then this code waits upto a max of 20 MS to proceed else timeout.
future.get(20MS)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
