YongGang commented on code in PR #16041:
URL: https://github.com/apache/druid/pull/16041#discussion_r1575036902
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -512,6 +516,8 @@ public boolean add(final Task task)
SinglePhaseParallelIndexTaskRunner.DEFAULT_USE_LINEAGE_BASED_SEGMENT_ALLOCATION
);
+ taskContextEnricher.enrichContext(task);
Review Comment:
This is a normal interface (instead of an extension point), the default
implementation is `Noop`.
Seems to me it will be overly protected by using try-catch and Future for
such code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
