YongGang commented on code in PR #16325:
URL: https://github.com/apache/druid/pull/16325#discussion_r1577050862
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -424,15 +426,16 @@ private void manageInternalCritical(
catch (Exception e) {
log.warn(e, "Exception thrown during isReady for task: %s",
task.getId());
final String errorMessage;
- if (e instanceof MaxAllowedLocksExceededException) {
+ if (e instanceof MaxAllowedLocksExceededException || e instanceof
LockAcquisitionFailedException) {
errorMessage = e.getMessage();
} else {
errorMessage = StringUtils.format(
- "Encountered error[%s] while waiting for task to be ready.
See Overlord logs for more details.",
- StringUtils.chop(e.getMessage(), 100)
+ "Encountered error while waiting for task to be ready. See
Overlord logs for more details. Error: %s",
+ Throwables.getStackTraceAsString(e)
Review Comment:
`e.getMessage()` is probably enough, stacktrace is too long for task status
reporting I think.
##########
processing/src/main/java/org/apache/druid/indexer/TaskStatus.java:
##########
@@ -37,7 +37,7 @@
*/
public class TaskStatus
{
- public static final int MAX_ERROR_MSG_LENGTH = 100;
+ public static final int MAX_ERROR_MSG_TRUNCATION_LIMIT = 1024;
Review Comment:
I think the error msg will be shown in Druid console task status field, 1024
seems a bit long better check if it looks okay in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
