kfaraz commented on code in PR #16325:
URL: https://github.com/apache/druid/pull/16325#discussion_r1577161893
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/TaskLock.java:
##########
@@ -62,4 +63,17 @@ public interface TaskLock
boolean isRevoked();
boolean conflict(LockRequest request);
+
+ /**
+ * Checks if the lock is revoked and throws a {@link
LockAcquisitionFailedException} if so.
+ *
+ * @param interval The time interval for which the lock is acquired.
+ * @throws LockAcquisitionFailedException if the lock is revoked.
+ */
+ default void assertNotRevoked(Interval interval)
Review Comment:
It feels a little weird to pass the `interval` as an argument just to
include it in the exception message.
Should we use `TaskLock.getInterval()` itself instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
