IgorBerman commented on PR #16266:
URL: https://github.com/apache/druid/pull/16266#issuecomment-2075156683
@kfaraz thanks :) I looked at it and it seems nice approach.
I think the other PR is more generic since it permits to control which
lookups will be loaded. I haven't understood if it supports configuring it as
some context arguments for task.
In our case it's always all or nothing, but I can imagine more involved
environments.
For our usecase Compaction and Kill tasks are relevant and seems like it
will be easy to support Compaction task as well.
Additional diff that I can think of is that if we are not going to load
lookups current PR uses different guice module which might create lighter
runtime(i.e. less beans e.g., but I'm not sure this is the case since I'm not
too familiar with differences of those 2 modules really).
This is basically the other side of coin - to support higher flexibility
when making decision a bit later(when everything is initialized already and
only lookups are initialized) vs to make some decision during startup of
task(CliPeon)
Personally I'm in favor for other PR seems so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
