IgorBerman commented on PR #16266:
URL: https://github.com/apache/druid/pull/16266#issuecomment-2068623141
I see that 1 test failing:
org.apache.druid.indexing.overlord.ForkingTaskRunnerTest#testInvalidTaskContextJavaOptsArray
I've looked at it and for me it seems like some kind of race(meanwhile can't
figure out how it's connected to what I've did)
I believe there is some inter-tests dependency
getWorkerSuccessfulTaskCount & getWorkerFailedTaskCount are using static
variables
private static final AtomicLong FAILED_TASK_COUNT = new AtomicLong();
private static final AtomicLong SUCCESSFUL_TASK_COUNT = new AtomicLong();
both of them updated at
````
if (status.isSuccess()) {
SUCCESSFUL_TASK_COUNT.incrementAndGet();
} else {
FAILED_TASK_COUNT.incrementAndGet();
}
````
which doesn't happen when parsing of arguments failing here
````
List<String> taskJavaOptsArray = jsonMapper.convertValue(
task.getContextValue(ForkingTaskRunnerConfig.JAVA_OPTS_ARRAY_PROPERTY),
new TypeReference<List<String>>() {}
);
````
which throws exception and which is goes up to outer
````
catch (Throwable t) {
throw closer.rethrow(t);
}
````
i.e. those static variables are not incremented as part of failure to parse
arguments(maybe should be fixed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
