AmatyaAvadhanula commented on code in PR #16162:
URL: https://github.com/apache/druid/pull/16162#discussion_r1579013583
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriver.java:
##########
@@ -366,7 +373,11 @@ public void onSuccess(Object result)
{
if (numRemainingHandoffSegments.decrementAndGet() == 0) {
List<DataSegment> segments =
segmentsAndCommitMetadata.getSegments();
+ Set<DataSegment> upgradedSegments =
segmentsAndCommitMetadata.getUpgradedSegments();
log.info("Successfully handed off [%d] segments.",
segments.size());
+ if (upgradedSegments != null) {
+ log.info("Successfully handed off [%d] upgraded
segments.", upgradedSegments.size());
+ }
Review Comment:
Done, thanks
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderatorDriver.java:
##########
@@ -377,7 +388,8 @@ public void onSuccess(Object result)
new SegmentsAndCommitMetadata(
segments,
((AppenderatorDriverMetadata)
metadata).getCallerMetadata(),
-
segmentsAndCommitMetadata.getSegmentSchemaMapping()
+
segmentsAndCommitMetadata.getSegmentSchemaMapping(),
+ upgradedSegments
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
