kfaraz commented on code in PR #16162:
URL: https://github.com/apache/druid/pull/16162#discussion_r1579168117
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderator.java:
##########
@@ -527,8 +547,7 @@ private Sink getOrCreateSink(final SegmentIdWithShardSpec
identifier)
.emit();
}
- sinks.put(identifier, retVal);
- metrics.setSinkCount(sinks.size());
+ addSink(identifier, retVal);
sinkTimeline.add(retVal.getInterval(), retVal.getVersion(),
identifier.getShardSpec().createChunk(retVal));
Review Comment:
This line is already moved inside `addSink()` method. Should it be removed
from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
