github-advanced-security[bot] commented on code in PR #16338:
URL: https://github.com/apache/druid/pull/16338#discussion_r1580233502
##########
processing/src/main/java/org/apache/druid/segment/VirtualColumn.java:
##########
@@ -240,6 +242,25 @@
return null;
}
+ /**
+ * Returns a group-by selector. Allows virtual columns to control their own
grouping behavior.
+ *
+ * @param columnName column name
+ * @param factory column selector factory
+ * @param deferExpressionDimensions active value of {@link
org.apache.druid.query.groupby.GroupByQueryConfig#CTX_KEY_DEFER_EXPRESSION_DIMENSIONS}
+ *
+ * @return selector, or null if this virtual column does not have a
specialized one
+ */
+ @Nullable
+ default GroupByVectorColumnSelector makeGroupByVectorColumnSelector(
+ String columnName,
Review Comment:
## Useless parameter
The parameter 'columnName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7313)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
