LakshSingla commented on code in PR #16338: URL: https://github.com/apache/druid/pull/16338#discussion_r1596273161
########## benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlExpressionBenchmark.java: ########## Review Comment: There's also `SqlGroupByBenchmark` that benchmarks the code with various distributions and cardinalities. Maybe we should benchmark the code with the string columns and different parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
