kfaraz commented on code in PR #16334:
URL: https://github.com/apache/druid/pull/16334#discussion_r1581717796
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/autoscaler/LagStats.java:
##########
@@ -46,4 +53,22 @@ public long getAvgLag()
{
return avgLag;
}
+
+ public long getPrefferedScalingMetric()
Review Comment:
Typo. This method should return the `AggregateFunction` object itself.
Please add a javadoc to this method too.
```suggestion
public AggregateFunction getAggregateForScaling()
```
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/autoscaler/LagStats.java:
##########
@@ -46,4 +53,22 @@ public long getAvgLag()
{
return avgLag;
}
+
+ public long getPrefferedScalingMetric()
Review Comment:
This method should return the `AggregateFunction` object itself. Please add
a javadoc to this method too.
```suggestion
public AggregateFunction getAggregateForScaling()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
