adithyachakilam commented on code in PR #16334:
URL: https://github.com/apache/druid/pull/16334#discussion_r1582147884
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/SeekableStreamSupervisorSpecTest.java:
##########
@@ -131,8 +135,21 @@ public void setUp()
monitorSchedulerConfig = EasyMock.mock(DruidMonitorSchedulerConfig.class);
supervisorStateManagerConfig =
EasyMock.mock(SupervisorStateManagerConfig.class);
supervisor4 = EasyMock.mock(SeekableStreamSupervisor.class);
+ lagStats = EasyMock.mock(LagStats.class);
+ timesLagStatsMaxCalled = 0;
+ timesLagStatsSumCalled = 0;
EasyMock.expect(spec.getContextValue(DruidMetrics.TAGS)).andReturn(null).anyTimes();
+
EasyMock.expect(lagStats.getAggregateForScaling()).andReturn(AggregateFunction.SUM).anyTimes();
+ EasyMock.expect(lagStats.getMetric(AggregateFunction.SUM)).andAnswer(() ->
{
+ timesLagStatsSumCalled++;
+ return 0L;
+ }).anyTimes();
+ EasyMock.expect(lagStats.getMetric(AggregateFunction.MAX)).andAnswer(() ->
{
+ timesLagStatsMaxCalled++;
+ return 0L;
+ }).anyTimes();
+ EasyMock.replay(lagStats);
Review Comment:
We can change to Boolean instead of int representing if that method is
called or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
