kfaraz commented on code in PR #15705:
URL: https://github.com/apache/druid/pull/15705#discussion_r1582489030
##########
server/src/main/java/org/apache/druid/server/coordinator/loading/CuratorLoadQueuePeon.java:
##########
@@ -72,7 +72,7 @@ public class CuratorLoadQueuePeon implements LoadQueuePeon
* with loading or dropping segments.
*/
private final ExecutorService callBackExecutor;
- private final DruidCoordinatorConfig config;
+ private final Duration loadTimeout;
private final AtomicLong queuedSize = new AtomicLong(0);
Review Comment:
We need not migrate the `LoadQueuePeonTest` as there is already an
`HttpLoadQueuePeonTest`.
There are some other tests though, such as `DruidCoordinatorTest` which will
need to be migrated to use the `HttpLoadQueuePeon`.
> > The code for ZK-based segment loading is not being removed yet as it
might be needed for testing purposes.
> Are we referring to the unit tests?
No, I wanted to retain it for now just in case we need to do an
implementation/perf comparison between the ZK and HTTP implementation, or if
there is an issue and we want to re-enable ZK.
Druid 31 will have the option removed. Druid 32 will have the code removed
completely as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
