zachjsh opened a new pull request, #16351:
URL: https://github.com/apache/druid/pull/16351
### Description
This pr contains a few fixes for clustering keys when stored in the Druid
table catalog.
1. `DESC` order clustering keys is disallowed; descending clustering keys is
not supported at this time by Druid, but previously users could create / update
a catalog table with clustering keys with `DESC` order via api. This is now
disallowed.
2. Fixed a bug where if when partitionedBy is stored in for a table in the
catalog, the user would still have to specify this partitioning if they also
wished to define the clustering keys at query time. The error in such a case
was coming from the SQL parsing layer. I've updated the respective ftl files to
allow for this, and this validation has moved to the `DruidSqlValidator`. In
such a case the user should be able to omit the partitioning at query time, and
still specify the clustering at query time.
3. Added more tests.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
