kgyrtkirk commented on code in PR #16351:
URL: https://github.com/apache/druid/pull/16351#discussion_r1589104266
##########
extensions-core/druid-catalog/src/test/java/org/apache/druid/server/http/catalog/EditorTest.java:
##########
@@ -374,6 +378,37 @@ public void testUpdateProperties() throws CatalogException
expected,
doEdit(tableName, cmd).spec().properties()
);
+
+ // Add a DESC cluster key - should fail
Review Comment:
could be placed in a new testscase
##########
extensions-core/druid-catalog/src/test/java/org/apache/druid/server/http/catalog/EditorTest.java:
##########
@@ -56,6 +60,7 @@
public class EditorTest
{
+ private static final ObjectMapper MAPPER = new DefaultObjectMapper();
Review Comment:
note: `dbFixture` also has an `OM` you could probably reuse that somehow;
I've seen some issue arising from using different objectmappers...
##########
server/src/test/java/org/apache/druid/catalog/model/table/DatasourceTableTest.java:
##########
@@ -116,6 +117,28 @@ public void testEmptySpec()
}
}
+ @Test
+ public void testSpecWithClusterKeyProp()
+ {
+ {
+ TableSpec spec = new TableSpec(
+ DatasourceDefn.TABLE_TYPE,
+ ImmutableMap.of(DatasourceDefn.CLUSTER_KEYS_PROPERTY,
ImmutableList.of(new ClusterKeySpec("clusterKeyA", true))),
+ null
+ );
+ expectValidationFails(spec);
+ }
+
+ {
Review Comment:
aren't these 2 separate testcases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
