This is an automated email from the ASF dual-hosted git repository.

kfaraz pushed a commit to branch 30.0.0
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/30.0.0 by this push:
     new 5992a5887fd Fix defaults of segment schema cleanup (#16354)
5992a5887fd is described below

commit 5992a5887fddf54e954d9f584364d1e730872206
Author: Kashif Faraz <[email protected]>
AuthorDate: Tue Apr 30 19:54:17 2024 +0530

    Fix defaults of segment schema cleanup (#16354)
---
 .../org/apache/druid/server/coordinator/DruidCoordinatorConfig.java   | 4 ++--
 .../apache/druid/server/coordinator/DruidCoordinatorConfigTest.java   | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
 
b/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
index 66123ab5ea6..9cd7fd48570 100644
--- 
a/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
+++ 
b/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
@@ -172,10 +172,10 @@ public abstract class DruidCoordinatorConfig
   public abstract boolean isSegmentSchemaKillEnabled();
 
   @Config("druid.coordinator.kill.segmentSchema.period")
-  @Default("PT1H")
+  @Default("P1D")
   public abstract Duration getSegmentSchemaKillPeriod();
 
   @Config("druid.coordinator.kill.segmentSchema.durationToRetain")
-  @Default("PT6H")
+  @Default("P90D")
   public abstract Duration getSegmentSchemaKillDurationToRetain();
 }
diff --git 
a/server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorConfigTest.java
 
b/server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorConfigTest.java
index 6f1a0504587..a36fc9e7edf 100644
--- 
a/server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorConfigTest.java
+++ 
b/server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorConfigTest.java
@@ -39,11 +39,13 @@ public class DruidCoordinatorConfigTest
     Assert.assertEquals(new Duration("PT60s"), config.getCoordinatorPeriod());
     Assert.assertEquals(new Duration("PT1800s"), 
config.getCoordinatorIndexingPeriod());
     Assert.assertEquals(new Duration("PT1800s"), 
config.getCoordinatorKillPeriod());
-    Assert.assertEquals(new Duration("PT7776000s"), 
config.getCoordinatorKillDurationToRetain());
+    Assert.assertEquals(Duration.standardDays(90), 
config.getCoordinatorKillDurationToRetain());
     Assert.assertEquals(100, config.getCoordinatorKillMaxSegments());
     Assert.assertEquals(new Duration(15 * 60 * 1000), 
config.getLoadTimeoutDelay());
     Assert.assertFalse(config.getCoordinatorKillIgnoreDurationToRetain());
     Assert.assertEquals("http", config.getLoadQueuePeonType());
+    Assert.assertEquals(Duration.standardDays(1), 
config.getSegmentSchemaKillPeriod());
+    Assert.assertEquals(Duration.standardDays(90), 
config.getSegmentSchemaKillDurationToRetain());
   }
 
   @Test


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to