jgoz opened a new pull request, #16359:
URL: https://github.com/apache/druid/pull/16359

   ### Description
   
   Moves Druid SQL autocomplete information into the `dsql` mode itself and out 
of flexible-query-input to allow any `AceEditor` instance access to those 
completions via the mode.
   
   Some other Ace-related changes:
   - Convert dsql and hjson modes to TypeScript
   - Avoid adding local completions to the global langTools extension in 
flexible-query-input — ensures that completions are scoped to a specific 
component instance and do not leak across instances
   - Change font size to 12 in all editors
   - Make `theme` configurable via static member
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to