AmatyaAvadhanula commented on PR #16362:
URL: https://github.com/apache/druid/pull/16362#issuecomment-2087858877
Idea looks good to me @IgorBerman.
1) Kill tasks must hold a lock to avoid conflicts with every other Fixed
Interval Task types.
Move, Restore and Archive tasks change the set of used segments, and should
always use an exclusive lock.
2) Although Kill tasks can coexist with other types of tasks such as other
appending tasks even without concurrent append and replace, using a SHARED or
APPEND lock introduces the possibility of having multiple kill tasks running
for the same interval. Using EXCLUSIVE lock as the default seems right to me,
and REPLACE locks with concurrent append / replace. A user may choose to use
SHARED / APPEND when they are certain that there are no duplicate kill tasks or
when that is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
