IgorBerman commented on code in PR #16362:
URL: https://github.com/apache/druid/pull/16362#discussion_r1587109043
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractFixedIntervalTask.java:
##########
@@ -77,10 +77,15 @@ protected AbstractFixedIntervalTask(
@Override
public boolean isReady(TaskActionClient taskActionClient) throws Exception
+ {
+ return isReady(taskActionClient, TaskLockType.EXCLUSIVE);
+ }
+
+ protected boolean isReady(TaskActionClient taskActionClient, TaskLockType
taskLockType) throws Exception
Review Comment:
@abhishekrb19 thanks for the suggestion, wdyt about following:
parent's isReady() uses private field of `interval`, so either we convert it
to protected or leave some base method
do you think it will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
