kfaraz commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1588775853
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTask.java:
##########
@@ -185,4 +189,15 @@ public int hashCode()
{
return Objects.hash(super.hashCode(), controllerTaskId, workerNumber,
retryCount, worker);
}
+
+ @Override
+ public LookupLoadingSpec getLookupLoadingSpec()
+ {
+ if (getContext().containsKey(PlannerContext.CTX_LOOKUPS_TO_LOAD)) {
+ List<String> lookupsToLoad = (List<String>)
getContext().get(PlannerContext.CTX_LOOKUPS_TO_LOAD);
+ return lookupsToLoad.isEmpty() ? LookupLoadingSpec.NONE :
LookupLoadingSpec.loadOnly(new HashSet<>(lookupsToLoad));
Review Comment:
Hmm, I am kind of on-the-fence with this.
__Pro:__ Having the extra parameter does have the advantage of explicitly
specifying what loading mode we want to use.
__Con:__ On the other hand, it has the added code and UX complexity of
handling the other parameter and ensuring that the behaviour of the two is
consistent with each other.
For consistency with the `getLookupLoadingSpec` method, I guess we will have
to live with the added complexity. Otherwise, `null` and empty start having
different meanings and that is always bound to create trouble.
So, we need:
lookupLoadingMode = null or not set -> load ALL (default behaviour)
lookupLoadingMode = ALL -> load ALL
lookupLoadingMode = NONE -> load NONE
In the 3 cases above, the `lookupsToLoad` field must be null or not set at
all.
lookupLoadingMode = ONLY_REQUIRED
In this case, `lookupsToLoad` must be specified as a non-null non-empty list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
