Akshat-Jain commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1589090644
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTask.java:
##########
@@ -185,4 +189,15 @@ public int hashCode()
{
return Objects.hash(super.hashCode(), controllerTaskId, workerNumber,
retryCount, worker);
}
+
+ @Override
+ public LookupLoadingSpec getLookupLoadingSpec()
+ {
+ if (getContext().containsKey(PlannerContext.CTX_LOOKUPS_TO_LOAD)) {
Review Comment:
> I think this method of getting something from context and getting a
lookupLoading spec should be in an utility class since this would be used in
multiple places.
I think this is a non-problem in the newer approach, since MSQControllerTask
has been updated to return NONE, and MSQWorkerTask also has some modifications
in the logic. We can refactor it into a common place if needed in future though.
> I donot see the context key's being passed to the worker.
I could see lookups being loaded selectively on the worker nodes. I also
verified the values in the worker payload as we discussed earlier today. With
that said, the PR has been updated to the new approach we discussed, so please
have a look at the latest code changes once. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
