kaisun2000 commented on code in PR #16409:
URL: https://github.com/apache/druid/pull/16409#discussion_r1592776334
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderator.java:
##########
@@ -465,6 +465,7 @@ public void onFailure(Throwable t)
MoreExecutors.directExecutor()
);
} else {
+ log.info("Set persist flag for the reason: %s.", String.join(",",
persistReasons));
Review Comment:
I also noticed it. The reason I decided to add another line in the
non-incremental code path is to distinguish the logging between the two path.
As incremental path is to call persistAll immediatelywhile this code path is to
set flag and do async persist later. Do you feel we need the distinction? If
not, I will make the adjustment to move the line out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
