kfaraz commented on code in PR #16409:
URL: https://github.com/apache/druid/pull/16409#discussion_r1594880005
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/StreamAppenderator.java:
##########
@@ -465,6 +465,7 @@ public void onFailure(Throwable t)
MoreExecutors.directExecutor()
);
} else {
+ log.info("Set persist flag for the reason: %s.", String.join(",",
persistReasons));
Review Comment:
I think it makes sense to have the distinction. But the log line should
reflect that this is the non-incremental code path.
```suggestion
log.info("Marking ready for non-incremental async persist due to
reasons[%s].", persistReasons);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
