georgew5656 commented on code in PR #16386:
URL: https://github.com/apache/druid/pull/16386#discussion_r1593137243
##########
distribution/docker/druid.sh:
##########
@@ -138,8 +138,8 @@ then
setKey _common druid.zk.service.host "${ZOOKEEPER}"
fi
-DRUID_SET_HOST=${DRUID_SET_HOST:-1}
-if [ "${DRUID_SET_HOST}" = "1" ]
+DRUID_SET_HOST_IP=${DRUID_SET_HOST_IP:-0}
Review Comment:
@aho135 does this new default work okay with a raw docker run? i'm not
exactly sure what
InetAddress.getLocalHost().getCanonicalHostName() returns there? i think it
might be the container-id which might not work that well since its not reachable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
