Akshat-Jain opened a new pull request, #16420: URL: https://github.com/apache/druid/pull/16420
### Description This PR updates CompactionTask to not load any lookups by default. This behavior can be overridden by supplying `lookupLoadingMode` and `lookupsToLoad` in the task context. Other changes/refactoring: 1. Moved CTX_LOOKUP_LOADING_MODE and CTX_LOOKUPS_TO_LOAD constants from PlannerContext to LookupLoadingSpec, as PlannerContext wasn't available in the indexing module. 2. Moved logic for evaluating the context and creating LookupLoadingSpec based on that to `LookupLoadingSpec#getSpecFromContext`. 3. Updated `Task#getLookupLoadingSpec` to return `LookupLoadingSpec.getSpecFromContext(getContext(), LookupLoadingSpec.ALL)`. The default `ALL` ensures that no existing behavior is broken, unless context has been overridden. Making this change in `Task` interface prevents us from having to make this change in a bunch of tasks that are spawned by CompactionTask. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
