LakshSingla commented on code in PR #16322:
URL: https://github.com/apache/druid/pull/16322#discussion_r1595192971
##########
processing/src/test/java/org/apache/druid/frame/write/FrameWriterTestData.java:
##########
@@ -270,8 +268,9 @@ public class FrameWriterTestData
HyperUniquesAggregatorFactory.TYPE,
Arrays.asList(
null,
- makeHllCollector(null),
- makeHllCollector("foo")
+ ByteRowKeyComparatorTest.makeHllCollector(1),
Review Comment:
The reason I didn't add nested data type was that it's sortedness isn't
apparent. It generates a hash of the objects, and compares that hash. I'll add
a separate dataset for the nested columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
