gianm commented on PR #16322: URL: https://github.com/apache/druid/pull/16322#issuecomment-2103192624
> Regarding the `msqIncompatible`, I figured out that about a half of them were failing due to not reading the correct file in the test case. I didn't inspect them deeply while allowing the nested tests on MSQ since the group by ones (that I was primarily interested in) were correctly working with MSQ. So the tests were failing with incorrect results because the dataset (all_auto) wasn't same between MSQ and the native tests. > > I have fixed up those test cases and resolved the comments pertaining to those tests. Thank you! Good to know, I was worried something was wrong with the implementation on the MSQ side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
