Akshat-Jain commented on code in PR #16420:
URL: https://github.com/apache/druid/pull/16420#discussion_r1597975859
##########
server/src/main/java/org/apache/druid/server/lookup/cache/LookupLoadingSpec.java:
##########
@@ -80,6 +88,34 @@ public ImmutableSet<String> getLookupsToLoad()
return lookupsToLoad;
}
+ public static LookupLoadingSpec createFromContext(Map<String, Object>
context, LookupLoadingSpec defaultSpec)
Review Comment:
@cryptoe IIUC, the suggestion is to have a `Map<String, Object>
defaultContext` as a class variable in LookupLoadingSpec class?
Then the clients would have to update defaultContext in most cases, which
seems unnecessary.
Another option could be to add another method:
```java
public static LookupLoadingSpec createFromContext(Map<String, Object>
context) {
return createFromContext(context, LookupLoadingSpec.ALL);
}
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
