Akshat-Jain commented on code in PR #16420:
URL: https://github.com/apache/druid/pull/16420#discussion_r1597976352
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -249,6 +250,14 @@ public CompactionTask(
this.segmentProvider = new SegmentProvider(dataSource,
this.ioConfig.getInputSpec());
this.partitionConfigurationManager = new
PartitionConfigurationManager(this.tuningConfig);
this.segmentCacheManagerFactory = segmentCacheManagerFactory;
+
+ // Do not load any lookups in sub-tasks launched by compaction task,
unless transformSpec is present.
+ // If transformSpec is present, we will not modify the context so that the
sub-tasks can make the
+ // decision based on context values, loading all lookups by default.
+ // This is done to ensure backward compatibility since transformSpec can
reference lookups.
+ if (transformSpec == null) {
+ addToContextIfAbsent(LookupLoadingSpec.CTX_LOOKUP_LOADING_MODE,
LookupLoadingSpec.Mode.NONE.toString());
+ }
Review Comment:
@cryptoe That fallback is present in `Task.java`, so adding it here would be
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
