Codegass commented on code in PR #16436:
URL: https://github.com/apache/druid/pull/16436#discussion_r1598382001
##########
extensions-core/parquet-extensions/src/test/java/org/apache/druid/data/input/parquet/DecimalParquetInputTest.java:
##########
@@ -148,13 +148,12 @@ public void testReadParquetDecimali32() throws
IOException, InterruptedException
public void testReadParquetDecimali64() throws IOException,
InterruptedException
{
// parquet-avro does not correctly convert decimal types
- if
(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE)) {
- return;
- }
+
assumeFalse(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE));
+
HadoopDruidIndexerConfig config = transformHadoopDruidIndexerConfig(
- "example/decimals/dec_in_i64.json",
- parserType,
- true
+ "example/decimals/dec_in_i64.json",
Review Comment:
thank you for the suggestions! I just updated the pr based on them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
