kfaraz commented on code in PR #16436:
URL: https://github.com/apache/druid/pull/16436#discussion_r1599686667
##########
extensions-core/parquet-extensions/src/test/java/org/apache/druid/data/input/parquet/DecimalParquetInputTest.java:
##########
@@ -101,13 +101,12 @@ public void testReadParquetDecimalFixedLen() throws
IOException, InterruptedExce
public void testReadParquetDecimali32() throws IOException,
InterruptedException
{
// parquet-avro does not correctly convert decimal types
- if
(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE)) {
- return;
- }
+
Assume.assumeFalse(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE));
+
HadoopDruidIndexerConfig config = transformHadoopDruidIndexerConfig(
- "example/decimals/dec_in_i32.json",
- parserType,
- true
+ "example/decimals/dec_in_i32.json",
+ parserType,
+ true
Review Comment:
```suggestion
"example/decimals/dec_in_i32.json",
parserType,
true
```
##########
extensions-core/parquet-extensions/src/test/java/org/apache/druid/data/input/parquet/DecimalParquetInputTest.java:
##########
@@ -54,13 +55,12 @@ public DecimalParquetInputTest(String parserType)
public void testReadParquetDecimalFixedLen() throws IOException,
InterruptedException
{
// parquet-avro does not correctly convert decimal types
- if
(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE)) {
- return;
- }
+
Assume.assumeFalse(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE));
+
HadoopDruidIndexerConfig config = transformHadoopDruidIndexerConfig(
- "example/decimals/dec_in_fix_len.json",
- parserType,
- true
+ "example/decimals/dec_in_fix_len.json",
+ parserType,
+ true
Review Comment:
```suggestion
"example/decimals/dec_in_fix_len.json",
parserType,
true
```
##########
extensions-core/parquet-extensions/src/test/java/org/apache/druid/data/input/parquet/DecimalParquetInputTest.java:
##########
@@ -148,13 +147,12 @@ public void testReadParquetDecimali32() throws
IOException, InterruptedException
public void testReadParquetDecimali64() throws IOException,
InterruptedException
{
// parquet-avro does not correctly convert decimal types
- if
(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE)) {
- return;
- }
+
Assume.assumeFalse(parserType.equals(ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE));
+
HadoopDruidIndexerConfig config = transformHadoopDruidIndexerConfig(
- "example/decimals/dec_in_i64.json",
- parserType,
- true
+ "example/decimals/dec_in_i64.json",
+ parserType,
+ true
Review Comment:
```suggestion
"example/decimals/dec_in_i64.json",
parserType,
true
```
##########
extensions-core/parquet-extensions/src/test/java/org/apache/druid/data/input/parquet/DecimalParquetInputTest.java:
##########
@@ -38,8 +39,8 @@ public class DecimalParquetInputTest extends
BaseParquetInputTest
public static Iterable<Object[]> constructorFeeder()
{
return ImmutableList.of(
- new Object[]{ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE},
- new Object[]{ParquetExtensionsModule.PARQUET_SIMPLE_INPUT_PARSER_TYPE}
+ new Object[]{ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE},
+ new
Object[]{ParquetExtensionsModule.PARQUET_SIMPLE_INPUT_PARSER_TYPE}
Review Comment:
```suggestion
new Object[]{ParquetExtensionsModule.PARQUET_AVRO_INPUT_PARSER_TYPE},
new
Object[]{ParquetExtensionsModule.PARQUET_SIMPLE_INPUT_PARSER_TYPE}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
