abhishekrb19 commented on code in PR #16250:
URL: https://github.com/apache/druid/pull/16250#discussion_r1602376710
##########
web-console/src/dialogs/doctor-dialog/doctor-checks.tsx:
##########
@@ -291,61 +297,45 @@ export const DOCTOR_CHECKS: DoctorCheck[] = [
},
},
{
- name: 'Verify that there are historical services',
+ name: 'Verify that there are historicals and they are not too full',
check: async controls => {
- // Make sure that there are broker and historical services reported from
sys.servers
- let sqlResult: any[];
+ // Make sure that no services are reported that are over 95% capacity
+ let historicalFills: HistoricalFill[];
try {
- sqlResult = await queryDruidSql({
+ historicalFills = await queryDruidSql({
query: `SELECT
- COUNT(*) AS "historicals"
+ "server" AS "historical",
+ "curr_size" * 100.0 / "max_size" AS "fill"
FROM sys.servers
-WHERE "server_type" = 'historical'`,
+WHERE "server_type" = 'historical'
+ORDER BY "fill" DESC`,
});
+ // Note: for some reason adding ` AND "curr_size" * 100.0 / "max_size"
> 90` to the filter does not work as off this writing Apr 8, 2024
Review Comment:
```suggestion
// Note: for some reason adding ` AND "curr_size" * 100.0 /
"max_size" > 90` to the filter does not work as of this writing Apr 8, 2024
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
