abhishekrb19 commented on PR #16475: URL: https://github.com/apache/druid/pull/16475#issuecomment-2121910215
> > IIUC, this PR is basically doing the following: > > * Inject the correct value of storage locations into `SegmentLoadDropHandler` > * Refactor and cleanup classes > That's about right, except that we're not injecting storage locations into `SegmentLoadDropHandler` to fix it. Instead, `SegmentLoadDropHandler` relies on `SegmentManager` and `SegmentCacheManager` to provide the needed information. With this patch, `SegmentCacheManager` essentially serves as the source of truth for low-level segment info file operations. > Is there any other bug fix or feature included in this PR too? Just wanted to confirm before I start the actual review. There's no other bug fix or feature in this PR. I do have another related change that touches some of this code, but given the size of this PR, I will add it separately to make reviewing easier. 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
