abhishekrb19 commented on code in PR #16475:
URL: https://github.com/apache/druid/pull/16475#discussion_r1614210822
##########
server/src/main/java/org/apache/druid/server/SegmentManager.java:
##########
@@ -262,8 +262,12 @@ public boolean loadSegment(final DataSegment segment,
boolean lazy, SegmentLazyL
*
* @throws SegmentLoadingException if the segment cannot be loaded
*/
- public boolean loadSegment(final DataSegment segment, boolean lazy,
SegmentLazyLoadFailCallback loadFailed,
- ExecutorService loadSegmentIntoPageCacheExec)
throws SegmentLoadingException
+ public boolean loadSegment(
+ final DataSegment segment,
+ boolean lazy,
+ SegmentLazyLoadFailCallback loadFailed,
+ ExecutorService loadSegmentIntoPageCacheExec
+ ) throws SegmentLoadingException, IOException
Review Comment:
Cleaned up the existing patterns a bit. `loadSegment()` doesn't require an
async load fail callback as there's no lazy loading done in this flow. Only
`loadSegmentOnBootstrap()` requires that based on `lazyLoadOnStart`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
