sreemanamala commented on code in PR #16482:
URL: https://github.com/apache/druid/pull/16482#discussion_r1609166731
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java:
##########
@@ -270,6 +278,74 @@ public static Windowing fromCalciteStuff(
}
}
+ /**
+ * A wrapper object which stores {@link
org.apache.calcite.rel.core.Window.Group}
+ * along with its computed {@link WindowOperatorFactory}
+ *
+ * this allows us to sort the window groups in order to optimise the order
of operators we would need to compute
+ * without losing the aggregate column name information (which is part of
the computed WindowOperatorFactory)
+ */
+ private static class WindowGroupProcessorWrapper implements
Comparable<WindowGroupProcessorWrapper>
Review Comment:
Modified. Now we can have multiple comparators.
I thought that we would not be requiring multiple, at the end we might have
to only use the comparator that would optimise us to use minimal operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
