Akshat-Jain commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1617223193
########## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3UploadManager.java: ########## Review Comment: @LakshSingla Have made `updateChunkSizeIfGreater()` synchronized, and reverted back `maxConcurrentNumChunks` from `AtomicInteger` to `int`. All other methods don't need to be marked synchronized. `recomputeMaxConcurrentNumChunks()` is called only from the above synchronized method, and the other methods either read something, or update an atomic variable. Hope this works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
