kfaraz commented on code in PR #16528:
URL: https://github.com/apache/druid/pull/16528#discussion_r1623498997


##########
server/src/main/java/org/apache/druid/curator/discovery/CuratorDruidLeaderSelector.java:
##########
@@ -70,6 +71,8 @@ public CuratorDruidLeaderSelector(CuratorFramework curator, 
@Self DruidNode self
     // election until LeaderLatch.start() is called in registerListener(). 
This allows clients to observe the current
     // leader without being involved in the election.
     this.leaderLatch.set(createNewLeaderLatch());
+
+    
curator.getConnectionStateListenable().addListener(this::handleConnectionStateChanged);

Review Comment:
   I don't think we need this now since we are already recreating the latch 
when `notLeader` is called.
   See https://github.com/apache/druid/pull/16528#discussion_r1623237401 for 
reference. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to