clintropolis commented on code in PR #16577:
URL: https://github.com/apache/druid/pull/16577#discussion_r1631786512
##########
processing/src/main/java/org/apache/druid/segment/serde/NestedCommonFormatColumnPartSerde.java:
##########
@@ -303,10 +303,6 @@ public void read(ByteBuffer buffer, ColumnBuilder builder,
ColumnConfig columnCo
bitmapSerdeFactory,
byteOrder
);
- ColumnCapabilitiesImpl capabilitiesBuilder =
builder.getCapabilitiesBuilder();
Review Comment:
ah, put in the description:
>While here also noticed that COMPLEX<json> was needlessly reporting itself
as dictionary encoded, which isn't quite true. While the nested field columns
are dictionary encoded, the json values themselves are not, so functions like
TO_JSON_STRING could also run into this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
