clintropolis commented on code in PR #16577:
URL: https://github.com/apache/druid/pull/16577#discussion_r1631790888
##########
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionPlan.java:
##########
@@ -277,6 +277,9 @@ public ColumnCapabilities inferColumnCapabilities(@Nullable
ColumnType outputTyp
// until query time
return ColumnCapabilitiesImpl.copyOf(underlyingCapabilities)
.setType(ColumnType.STRING)
+ // this is sad, but currently
dictionary encodedness is tied to string
+ // selectors and sad stuff happens if
the input type isn't string
+
.setDictionaryEncoded(underlyingCapabilities.is(ValueType.STRING))
Review Comment:
actually, we were explicitly marking hasBitmapIndexes as false, though
#15585 allows expressions to use them in many cases, so it probably should be
allowed to pass through. `hasBitmapIndexes` and `hasSpatialIndexes` should
probably be removed from `ColumnCapabilities`, and the write side stuff that
currently uses it be moved to `ColumnFormat`, though not going to do that on
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
