kfaraz commented on code in PR #16291:
URL: https://github.com/apache/druid/pull/16291#discussion_r1634122175
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -1263,16 +1047,19 @@ public static class Builder
private TuningConfig tuningConfig;
@Nullable
private Map<String, Object> context;
+ private CompactionRunner compactionRunner;
public Builder(
String dataSource,
SegmentCacheManagerFactory segmentCacheManagerFactory,
- RetryPolicyFactory retryPolicyFactory
+ RetryPolicyFactory retryPolicyFactory,
+ CompactionRunner compactionRunner
Review Comment:
Not needed in the constructor here as you have already added a separate
builder method to set the `compactionRunner`. Fields passed to the constructor
of the builder must be final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
