LakshSingla commented on code in PR #16511:
URL: https://github.com/apache/druid/pull/16511#discussion_r1635854626
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -186,6 +188,7 @@ public static Pair<Grouper<RowBasedKey>,
Accumulator<AggregateResult, ResultRow>
@Nullable final ReferenceCountingResourceHolder<ByteBuffer>
combineBufferHolder,
final int concurrencyHint,
final LimitedTemporaryStorage temporaryStorage,
+ final ObjectMapper jsonMapper,
final ObjectMapper spillMapper,
Review Comment:
When writing the code, this seemed natural, since we are using spillMapper
for the spilling runner, and nothing else. After going through the group by
code again, I think we should still be using the jsonMapper.
The input rows which get further deserialized according to the complex types
are sourced from:
1.
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByRowProcessor.java#L90
- The input rows are from the processed subqueries.
2.
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunner.java#L254C54-L254C55
- The input rows are to the mergeRunner, which has already been read from the
segments by the createRunner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
