LakshSingla commented on code in PR #16511:
URL: https://github.com/apache/druid/pull/16511#discussion_r1636858245
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java:
##########
@@ -186,6 +188,7 @@ public static Pair<Grouper<RowBasedKey>,
Accumulator<AggregateResult, ResultRow>
@Nullable final ReferenceCountingResourceHolder<ByteBuffer>
combineBufferHolder,
final int concurrencyHint,
final LimitedTemporaryStorage temporaryStorage,
+ final ObjectMapper jsonMapper,
final ObjectMapper spillMapper,
Review Comment:
Retested stuff, serde in (2) is not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
