kfaraz commented on code in PR #16613:
URL: https://github.com/apache/druid/pull/16613#discussion_r1640782314
##########
processing/src/main/java/org/apache/druid/java/util/emitter/service/SegmentMetadataEvent.java:
##########
@@ -85,7 +86,7 @@ public SegmentMetadataEvent(
)
{
this.dataSource = dataSource;
- this.createdTime = createdTime;
+ this.createdTime = createdTime != null ? createdTime : DateTimes.nowUtc();
Review Comment:
Nit: I don't think this field is ever passed in the current usages of this
class.
##########
processing/src/main/java/org/apache/druid/java/util/emitter/service/SegmentMetadataEvent.java:
##########
@@ -104,6 +105,7 @@ public EventMap toMap()
return EventMap.builder()
.put(FEED, getFeed())
+ .put("timestamp", createdTime.toString())
Review Comment:
It makes sense to set the `timestamp` field, but if we are emitting this
with the `SegmentMetadataEvent`, we probably don't need the `createdTime`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
