kfaraz commented on code in PR #16613:
URL: https://github.com/apache/druid/pull/16613#discussion_r1641242997
##########
processing/src/main/java/org/apache/druid/java/util/emitter/service/SegmentMetadataEvent.java:
##########
@@ -104,6 +105,7 @@ public EventMap toMap()
return EventMap.builder()
.put(FEED, getFeed())
+ .put("timestamp", createdTime.toString())
Review Comment:
Yeah, I assumed that you retained it for backwards compat.
But I think it is fine to make a breaking change in this case as I don't
think there would be a lot of downstream applications relying on this
particular event. At least I have not come across any major use cases.
Moreover, as you point out in the description, this event was already behaving
differently than the other emitted events. So it's okay to fix that up.
Although, if you feel differently and have come across applications that
depend on the `createdTime` field, we can retain it while marking it as
deprecated so that we can get rid of it eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
