kgyrtkirk commented on PR #16615:
URL: https://github.com/apache/druid/pull/16615#issuecomment-2173281809
I think that change is the finalization stuff in action; how the
finalization happens after these changes?
I'm not sure if forcing the column name would be the best - as for some
reason the original aggfactory have decided to add a postagg - we can't really
ignore that....if the base aggregate factory is not prepared to do the
finalization implicitly then I guess that might go south...so I think we should
probably look for some alternate path:
* fix finalization support correctly
* prefferably by moving the finalization to a separate project or
something
* create an autofinalized cover for the aggregates -
* make it clear that these aggregators are not supported in windowing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
