kgyrtkirk commented on code in PR #16615:
URL: https://github.com/apache/druid/pull/16615#discussion_r1674030053


##########
extensions-core/stats/src/test/java/org/apache/druid/query/aggregation/variance/sql/VarianceSqlAggregatorTest.java:
##########
@@ -698,4 +701,28 @@ public void testVarianceAggAsInput()
         expectedResults
     );
   }
+
+  @Test
+  public void testOverWindow()
+  {
+    testBuilder()
+        .sql(
+            "select dim4, dim5, mod(m1, 3), var_pop(mod(m1, 3)) over 
(partition by dim4 order by dim5) c\n"
+            + "from numfoo\n"
+            + "group by dim4, dim5, mod(m1, 3)")
+        .queryContext(ImmutableMap.of(
+            PlannerContext.CTX_ENABLE_WINDOW_FNS, true,
+            QueryContexts.ENABLE_DEBUG, true,
+            QueryContexts.WINDOWING_STRICT_VALIDATION, false

Review Comment:
   this will break the other PR; so after one of these gets merged - to other 
needs updates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to