Akshat-Jain commented on PR #16616:
URL: https://github.com/apache/druid/pull/16616#issuecomment-2174885516

   @kfaraz 
   
   > Do the same thing, just not in the wrapper, i.e. in 
S3UploadManager.queueChunkForUpload(), start a Stopwatch and inside the 
submitted lambda, determine the queued duration just before calling 
RetryUtils.retry().
   
   Makes sense, let me try it out! Thanks!
   
   > To determine queue size, you can keep an AtomicInteger which is 
incremented in the first line of queueChunkForUpload() and decremented inside 
the submitted lambda.
   
   Why not use `executor.getQueue().size()` like I was using currently in 
`WaitTimeMonitoringExecutorService#emitMetrics`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to