kfaraz commented on PR #16616: URL: https://github.com/apache/druid/pull/16616#issuecomment-2174892917
> Why not use executor.getQueue().size() like I was using currently in WaitTimeMonitoringExecutorService#emitMetrics? To do this, you need to update the interface to return a `ThreadPoolExecutor` instead of `ExecutorService`, which I am not sure if I really like 😛 , or cast the returned `ExecutorService` into a `ThreadPoolExecutor` anyway, which would probably be worse. Compared to this, maintaining the queue count in an integer is an easy workaround and not unclean either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
