kfaraz commented on code in PR #16616: URL: https://github.com/apache/druid/pull/16616#discussion_r1643898871
########## docs/operations/metrics.md: ########## @@ -298,6 +298,9 @@ If the JVM does not support CPU time measurement for the current thread, `ingest |`worker/task/assigned/count`|Number of tasks assigned to an indexer per emission period. This metric is only available if the `WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies| |`worker/task/completed/count`|Number of tasks completed by an indexer per emission period. This metric is only available if the `WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies| |`worker/task/running/count`|Number of tasks running on an indexer per emission period. This metric is only available if the `WorkerTaskCountStatsMonitor` module is included.|`dataSource`|Varies| +|`s3upload/threadPool/taskQueuedDuration`|Milliseconds spent by a task in queue before it starts uploading a part to S3 (in a multi-part upload) when durable storage is enabled.||Varies| +|`s3upload/threadPool/queuedTasks`|The number of tasks that are currently queued and waiting to upload a part to S3 (in a multi-part upload) when durable storage is enabled.||Varies| +|`s3upload/threadPool/taskDuration`|The time taken in milliseconds to upload a part to S3 (in a multi-part upload) when durable storage is enabled.|`uploadId`, `partNumber`|Varies| Review Comment: Better names: ``` s3upload/chunk/uploadTime s3upload/chunk/queuedTime s3upload/chunk/queueSize ``` Please also emit a metric from `RetryableS3OutputStream` which tracks total time taken to upload all chunks of a job, say (`s3upload/job/totalTime`). That would give us a good measure of the parallelism: parallelism is good if ``` s3upload/job/totalTime < sum(s3upload/chunk/uploadTime) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
